Allow passing non-default modules to pipeline #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override modules are recognized and replaced in the pipeline. However, no check is performed about mismatched classes yet. This is because the override module is already instantiated and we have no library or class name to compare against.
|
The documentation is not available anymore as the PR was closed or merged. |
|
I tried the following (as a quick hack before refactoring): for name, module in passed_class_obj.items():
# TODO: verify that the module class belongs to one of the supported classes
library_name, class_name = config_dict[name]
library = importlib.import_module(library_name)
loadable_classes = LOADABLE_CLASSES[library_name]
class_candidates = {c: getattr(library, c) for c in loadable_classes.keys()}
for class_name, class_candidate in class_candidates.items():
if isinstance(module, class_candidate):
init_kwargs[name] = module
# Remove it even if not found, as it's not appropriate
init_dict.pop(name)However, if we pass a scheduler instance to If we want to really verify this, I think we should create a more fine-grained mapping from module keys to supported classes, instead of checking all the loadable/importable classes in the library. |
anton-l
approved these changes
Aug 16, 2022
|
Just added a test, all other tests pass |
|
@anton-l - feel free to merge and then maybe also add it manually to the release notes quickly :-) |
|
Merging! |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Allow passing non-default modules to pipeline. Override modules are recognized and replaced in the pipeline. However, no check is performed about mismatched classes yet. This is because the override module is already instantiated and we have no library or class name to compare against. * up * add test Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #183.
Override modules are recognized and replaced in the pipeline. However, no check is performed about mismatched classes yet. This is because the override module is already instantiated (see https://github.com/huggingface/diffusers/blob/main/src/diffusers/configuration_utils.py#L223), and
init_dictin https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipeline_utils.py#L151 no longer has alibrary_nameor aclass_name- just the instantiated module.I'm looking at a way to detect a class mismatch so we can fail more gracefully.